Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

chore: change popular to Highly-used #1227

Merged
merged 1 commit into from
Jul 18, 2021

Conversation

stephenLYZ
Copy link
Contributor

@stephenLYZ stephenLYZ commented Jul 17, 2021

🏆 Enhancements

Change “Popular” to “Highly-used” and for the most popular charts https://github.com/apache/superset/projects/30#card-64852582

@stephenLYZ stephenLYZ requested a review from a team as a code owner July 17, 2021 06:50
@vercel
Copy link

vercel bot commented Jul 17, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/85bCf58Kwttm2rXfSCQk4akNqAyu
✅ Preview: https://superset-ui-git-fork-stephenlyz-change-popular-superset.vercel.app

@codecov
Copy link

codecov bot commented Jul 17, 2021

Codecov Report

Merging #1227 (05c4e10) into master (edd479a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1227   +/-   ##
=======================================
  Coverage   29.59%   29.59%           
=======================================
  Files         466      466           
  Lines        9559     9559           
  Branches     1571     1571           
=======================================
  Hits         2829     2829           
  Misses       6502     6502           
  Partials      228      228           
Impacted Files Coverage Δ
plugins/legacy-plugin-chart-world-map/src/index.js 0.00% <ø> (ø)
...acy-preset-chart-big-number/src/BigNumber/index.ts 0.00% <ø> (ø)
...reset-chart-big-number/src/BigNumberTotal/index.ts 0.00% <ø> (ø)
plugins/legacy-preset-chart-nvd3/src/Area/index.js 0.00% <ø> (ø)
...gins/legacy-preset-chart-nvd3/src/DistBar/index.js 0.00% <ø> (ø)
plugins/plugin-chart-echarts/src/Pie/index.ts 0.00% <ø> (ø)
...ugins/plugin-chart-echarts/src/Timeseries/index.ts 0.00% <ø> (ø)
...ugins/plugin-chart-pivot-table/src/plugin/index.ts 0.00% <ø> (ø)
plugins/plugin-chart-table/src/index.ts 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edd479a...05c4e10. Read the comment docs.

Copy link
Contributor

@xiezhongfu xiezhongfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for me

@rusackas rusackas merged commit e045475 into apache-superset:master Jul 18, 2021
@rusackas
Copy link
Member

rusackas commented Jul 18, 2021

CC @zhaoyongjie and @junlincc to make sure this change is indeed part of the plan - after I merged, I realized the task/card on the board doesn't explicitly ask for this change. It was, however, called out for in apache/superset#15734 (comment)

@stephenLYZ
Copy link
Contributor Author

hi @rusackas Sorry I didn't describe it clearly. This PR is about apache/superset#15734 (comment). Could you help me bump up version? Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants